Mvj 531 seasonal rent dates validation #752
Merged
+156
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NC-jsAhonen
reviewed
Oct 18, 2024
leasing/serializers/utils.py
Outdated
| if day is None and month is None: | ||
| return | ||
|
|
||
| if (day is None and month is not None) or (day is not None and month is None): |
There was a problem hiding this comment.
Could it be if day is None or month is None:? It is a bit simpler.
There was a problem hiding this comment.
Correct, I've added validation for both cases now though. So if one is None and other is not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RentDueDateSerializerfor due datesRentCreateUpdateSerializerfor valid season start and end "dates"This partly solves issues of MVJ-529, validation is only implemented at API level for Serializers. If MVJ-529 requires e.g. model level validation, it should be implemented separately. The logic would be almost the same, but the exception would come from django instead of django restframework